Skip to content

gix-url improvements #2271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 2, 2025
Merged

gix-url improvements #2271

merged 4 commits into from
Dec 2, 2025

Conversation

@Byron
Copy link
Member

@Byron Byron commented Nov 25, 2025 •
edited
Loading

Various AI powered improvements made by Sonnet.

Tasks

@Byron Byron force-pushed the improve-gix-url branch 4 times, most recently from 14cc13c to fefcb06 Compare November 25, 2025 08:38
@Byron Byron mentioned this pull request Dec 2, 2025
Merged
4 tasks
@Byron
refactor
e09b3d6 
- make bracket handling clearer
- improve field docs
- remove assert! as it is fine to not serialise everything in alternative forms.
  That's what canonical serialisation is there for.
- prefer strip instead of indexed operation
@Byron Byron marked this pull request as ready for review December 2, 2025 08:54
@Byron Byron enabled auto-merge December 2, 2025 08:55
@Byron
Copy link
Member Author

Byron commented Dec 2, 2025

This is very clearly much better than it was before. I used copilot to improve documentation as well, and find more opportunities for more idiomatic parsing.

@Byron Byron merged commit 169c17c into main Dec 2, 2025
28 checks passed
@Byron Byron deleted the improve-gix-url branch December 2, 2025 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Byron